Fix: Restrict non-owner from attaching pam scripts#2175
Merged
amangalampalli-ks merged 2 commits intoJun 29, 2026
Conversation
pvagare-ks
approved these changes
Jun 26, 2026
sali-ks
approved these changes
Jun 26, 2026
amangalampalli-ks
merged commit Jun 29, 2026
29bd055
into
fix/restrict-pam-rotation-script-attachment
4 checks passed
amangalampalli-ks
added a commit
that referenced
this pull request
Jun 29, 2026
* Flag rotation script uploads with is_script for owner-only server enforcement * Undo ssl changes
sk-keeper
pushed a commit
that referenced
this pull request
Jun 29, 2026
* Flag rotation script uploads with is_script for owner-only server enforcement * Undo ssl changes
sk-keeper
pushed a commit
that referenced
this pull request
Jul 2, 2026
* Flag rotation script uploads with is_script for owner-only server enforcement * Undo ssl changes
jpkeepersecurity
pushed a commit
that referenced
this pull request
Jul 3, 2026
* Flag rotation script uploads with is_script for owner-only server enforcement * Undo ssl changes
pvagare-ks
pushed a commit
that referenced
this pull request
Jul 16, 2026
* Flag rotation script uploads with is_script for owner-only server enforcement * Undo ssl changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commander now marks post-rotation script uploads so the backend can enforce owner-only attachment. Previously, script files were uploaded like normal attachments with no way for the server to tell them apart.
Changes
attachment.py— addis_scripton upload tasks; pass through tovault/files_add; clearer error on script upload rejectiondiscoveryrotation.py/discoveryrotation_v1.py— setis_script=TrueinPAMScriptAddCommandpam_import/base.py— same for PAM import script uploadsFileUploadTaskcallers unchanged (is_script=False)Tested
pam rotation script addsucceeds